Skip to content

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented May 26, 2025

TaskWPB-17693 [Android] nuke scala migration


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

it isabout time

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@pull-request-size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara changed the title chore: remove scala migration code and related references chore: remove scala migration code and related references [WPB-17693] May 26, 2025
@MohamadJaara MohamadJaara requested review from saleniuk and vitorhugods and removed request for saleniuk May 26, 2025 10:20
@MohamadJaara MohamadJaara enabled auto-merge May 26, 2025 10:41
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (2b38d30) to head (5789f7b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4036      +/-   ##
===========================================
+ Coverage    45.95%   47.73%   +1.78%     
===========================================
  Files          522      491      -31     
  Lines        18239    16991    -1248     
  Branches      3077     2822     -255     
===========================================
- Hits          8382     8111     -271     
+ Misses        8983     8046     -937     
+ Partials       874      834      -40     
Files with missing lines Coverage Δ
...tlin/com/wire/android/datastore/GlobalDataStore.kt 20.00% <ø> (+4.28%) ⬆️
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 74.30% <100.00%> (-1.47%) ⬇️
...com/wire/android/ui/debug/DebugDataOptionsState.kt 100.00% <ø> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 56.69% <ø> (+0.17%) ⬆️
.../main/kotlin/com/wire/android/ui/home/HomeState.kt 63.63% <ø> (-0.65%) ⬇️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 87.50% <ø> (+3.01%) ⬆️
...tlin/com/wire/android/util/CurrentScreenManager.kt 26.04% <ø> (+0.26%) ⬆️
...ire/android/util/lifecycle/SyncLifecycleManager.kt 96.87% <ø> (+2.43%) ⬆️
.../com/wire/android/workmanager/WireWorkerFactory.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b38d30...5789f7b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4036.apk is available for download

@github-actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4036.apk is available for download

@MohamadJaara MohamadJaara requested a review from ohassine May 27, 2025 07:43
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptions.kt
#	app/src/main/kotlin/com/wire/android/ui/migration/MigrationScreen.kt
#	app/src/test/kotlin/com/wire/android/ui/settings/debug/DebugDataOptionsViewModelTest.kt
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Built wire-android-staging-compat-pr-4036.apk is available for download

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Built wire-android-dev-debug-pr-4036.apk is available for download

@MohamadJaara MohamadJaara disabled auto-merge June 4, 2025 09:10
@MohamadJaara MohamadJaara enabled auto-merge June 4, 2025 09:10
@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 5, 2025
Merged via the queue into develop with commit 4227eb2 Jun 5, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the mo/chore/remove-scala-migration branch June 5, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants