Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Archive Kover report for debugging #567

Merged
merged 10 commits into from
Jun 14, 2022
Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Our Codecov reports have missing files

Causes

Under investigation

Solutions

Work in Progress:

  1. Archive report for debugging
  2. Next steps?

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Unit Test Results

120 files   -   14  120 suites   - 14   1m 0s ⏱️ +44s
579 tests +    2  571 ✔️ ±    0  8 💤 +2  0 ±0 
989 runs  +412  981 ✔️ +410  8 💤 +2  0 ±0 

Results for commit d96686f. ± Comparison against base commit 8006187.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #567 (a4b651f) into develop (4e54d8a) will decrease coverage by 8.25%.
The diff coverage is n/a.

❗ Current head a4b651f differs from pull request most recent head 0ac23c3. Consider uploading reports for the commit 0ac23c3 to get more accurate results

@@              Coverage Diff              @@
##             develop     #567      +/-   ##
=============================================
- Coverage      55.81%   47.56%   -8.26%     
- Complexity         0      635     +635     
=============================================
  Files            339      434      +95     
  Lines           6457    13027    +6570     
  Branches         619      976     +357     
=============================================
+ Hits            3604     6196    +2592     
- Misses          2631     6548    +3917     
- Partials         222      283      +61     

@yamilmedina yamilmedina self-requested a review June 3, 2022 07:54
@vitorhugods
Copy link
Member Author

Maybe it's codecov related? As it seems that the Kover report does contain all the files we want.

@yamilmedina
Copy link
Contributor

Maybe it's codecov related? As it seems that the Kover report does contain all the files we want.

Yeah it seems to, I tried changing the engine, but changed a bit only. Also I'm wondering and trying to understand if maybe codecov just omits interfaces 🤔 since those files looks like interfaces, but can't be sure yet.

Also as a ref, Kotlin/kotlinx-kover#117

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this so far as an intermedius step, also I agree that further investigation has to be made, all pointing to codecov misinterpreting the coverage file.

@vitorhugods
Copy link
Member Author

I think we're stuck here: https://docs.codecov.com/docs/fixing-paths

I'm trying to run a few reports without Codecov's default path fixing and with/without Jacoco's format to compare the XMLs and see how to make the path's match Git's paths.

@vitorhugods
Copy link
Member Author

I wrote my findings here: Kotlin/kotlinx-kover#189

As you said, @yamilmedina, it's better to leave the way it is for now, so at least we get SOME reporting. But in general it just seems that it's not currently supported by the couple Codecov + Kover.

The percentage is wrong, there are missing files, but it does help to see coverage going up or down to the files that aren't missing.

We just need to keep an eye open.

@vitorhugods vitorhugods force-pushed the ci/archive_kover_report branch from 0ac23c3 to e0b37eb Compare June 14, 2022 09:07
@vitorhugods vitorhugods merged commit 7b5bc37 into develop Jun 14, 2022
@vitorhugods vitorhugods deleted the ci/archive_kover_report branch June 14, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants