-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Archive Kover report for debugging #567
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #567 +/- ##
=============================================
- Coverage 55.81% 47.56% -8.26%
- Complexity 0 635 +635
=============================================
Files 339 434 +95
Lines 6457 13027 +6570
Branches 619 976 +357
=============================================
+ Hits 3604 6196 +2592
- Misses 2631 6548 +3917
- Partials 222 283 +61 |
Maybe it's codecov related? As it seems that the Kover report does contain all the files we want. |
Yeah it seems to, I tried changing the engine, but changed a bit only. Also I'm wondering and trying to understand if maybe codecov just omits interfaces 🤔 since those files looks like interfaces, but can't be sure yet. Also as a ref, Kotlin/kotlinx-kover#117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this so far as an intermedius step, also I agree that further investigation has to be made, all pointing to codecov misinterpreting the coverage file.
I think we're stuck here: https://docs.codecov.com/docs/fixing-paths I'm trying to run a few reports without Codecov's default path fixing and with/without Jacoco's format to compare the XMLs and see how to make the path's match Git's paths. |
I wrote my findings here: Kotlin/kotlinx-kover#189 As you said, @yamilmedina, it's better to leave the way it is for now, so at least we get SOME reporting. But in general it just seems that it's not currently supported by the couple Codecov + Kover. The percentage is wrong, there are missing files, but it does help to see coverage going up or down to the files that aren't missing. We just need to keep an eye open. |
0ac23c3
to
e0b37eb
Compare
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Our Codecov reports have missing files
Causes
Under investigation
Solutions
Work in Progress:
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.