-
Notifications
You must be signed in to change notification settings - Fork 6
fix: count self as team member [WPB-16121 ] 🍒 #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: count self as team member [WPB-16121 ] 🍒 #3350
Conversation
* fix: count self as a team member * remove the need to pass self user id * tests * chore: fix broken test --------- Co-authored-by: ohassine <[email protected]>
|
Test Results3 595 tests ±0 3 485 ✅ ±0 6m 24s ⏱️ -47s Results for commit 37e921c. ± Comparison against base commit d89a570. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
|
Branch | fix/count-self-as-team-member-cherry-pick |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 693.04 µs |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 323,276.45 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,350,218.37 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 26,961.14 µs |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3350 +/- ##
========================================
Coverage 53.71% 53.71%
========================================
Files 1336 1336
Lines 38127 38127
Branches 3877 3877
========================================
Hits 20480 20480
- Misses 16209 16210 +1
+ Partials 1438 1437 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 3485 Passed, 110 Skipped, 1m 6.74s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
when reporting team size self is not counted
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.