Skip to content

fix: count self as team member [WPB-16121 ] 🍒 #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 27, 2025

TaskWPB-16121 [Android] Implement new user properties

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

when reporting team size self is not counted

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

* fix: count self as a team member

* remove the need to pass self user id

* tests

* chore: fix broken test

---------

Co-authored-by: ohassine <[email protected]>
@MohamadJaara MohamadJaara enabled auto-merge March 31, 2025 10:56
Copy link
Contributor Author

github-actions bot commented Mar 31, 2025

Test Results

3 595 tests  ±0   3 485 ✅ ±0   6m 24s ⏱️ -47s
  615 suites ±0     110 💤 ±0 
  615 files   ±0       0 ❌ ±0 

Results for commit 37e921c. ± Comparison against base commit d89a570.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
com.wire.kalium.persistence.dao.UserDAOTest ‑ givenUsersInTheSameTeamAsSelf_whenCountTeamMembers_thenAmountCountedCorrectly[jvm]
com.wire.kalium.persistence.dao.UserDAOTest ‑ givenUsersInTheSameTeamAsSelf_whenCountTeamMembers_thenSelfIsCounted[jvm]

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 31, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.71%. Comparing base (d89a570) to head (37e921c).

Files with missing lines Patch % Lines
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3350   +/-   ##
========================================
  Coverage    53.71%   53.71%           
========================================
  Files         1336     1336           
  Lines        38127    38127           
  Branches      3877     3877           
========================================
  Hits         20480    20480           
- Misses       16209    16210    +1     
+ Partials      1438     1437    -1     
Files with missing lines Coverage Δ
...kalium/logic/data/analytics/AnalyticsRepository.kt 46.66% <100.00%> (ø)
.../kotlin/com/wire/kalium/persistence/dao/UserDAO.kt 95.41% <ø> (ø)
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 51.85% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89a570...37e921c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/count-self-as-team-member-cherry-pick
Commit report: 469a01f
Test service: kalium-jvm

✅ 0 Failed, 3485 Passed, 110 Skipped, 1m 6.74s Total Time

Merged via the queue into develop with commit daf2c11 Mar 31, 2025
22 checks passed
@MohamadJaara MohamadJaara deleted the fix/count-self-as-team-member-cherry-pick branch March 31, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants