-
-
Notifications
You must be signed in to change notification settings - Fork 76
docs: move composer install instructions to setup/install.md (#75) #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move composer install instructions to setup/install.md (#75) #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in improving our docs @EmiFunes91. It does appear, however, that you have used an AI-assisted tool to generate these edits that unfortunately do not fit with our documentation structure. Please see the comments below to better implement these changes.
) - Removed setup/install.md (duplicate location). - Moved installation commands to setup/installation.md under new section. - Added proper reference link in architecture/using-composer.md. - Ensured Markdown consistency and heading structure. - Resolves issue wintercms#75 as requested.
Hi @bennothommo, thanks again for your detailed feedback. I've now implemented all requested changes: Removed the unnecessary markdown code block tag. Moved both the Installing Winter via Composer and Configuring Winter sections to setup/installation.md, just below the Web-based Installation. Removed the previously added setup/install.md file, as suggested. All changes have been cleaned up and verified, and the conversations have been marked as resolved. I’ve also responded to each individual comment and marked them as resolved after applying the requested changes. Let me know if there's anything else to adjust — otherwise, it's ready for final review. Thanks again for the opportunity to contribute! |
- Removed redundant instructions from architecture/using-composer.md - Linked to setup/installation.md instead - Ensured clean structure and markdown compliance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor update: Changed my-winter-site to my-project to match the official installation guide at https://wintercms.com/install. Thanks again!
@EmiFunes91 thanks for your efforts, but unfortunately I cannot accept this PR in its current form, and it appears that you are using AI to make these edits, and it is not understanding the context of my suggestions. We'll go down a different route to implement the changes required to satisfy #75. Thanks again. |
Understood, thank you for your time and feedback. |
This pull request addresses issue #75 by moving the Composer installation instructions
from
architecture/using-composer.md
tosetup/install.md
, where they are more appropriately placed.Changes made:
composer create-project
block and related instructions.architecture/using-composer.md
to include a reference link to the new location.Benefits:
Closes #75