Skip to content

Conversation

@alpetric
Copy link
Collaborator

No description provided.

@claude
Copy link
Contributor

claude bot commented Dec 29, 2025

Claude finished @alpetric's task in 1m 20s —— View job


Reviewing PR #7466

  • Gather context and understand the changes
  • Review the code changes
  • Provide feedback

Review Summary

Overall Assessment: ✅ Approved

This PR adds a helpful documentation comment to docker-compose.yml explaining the need to set HOME=/tmp when running Windmill workers with a non-root/non-windmill UID.

What Changed

The PR adds two comment lines to the windmill_worker service environment section:

# If running with non-root/non-windmill UID (e.g., user: "1001:1001"),
# add: - HOME=/tmp

Code Quality

Positives:

  • The comment is clear and provides a concrete example (user: "1001:1001")
  • Good placement near related configuration (after WORKER_GROUP, before other commented options)
  • Follows the existing documentation comment style in the file

Minor Suggestions:

  1. Consider adding this to windmill_worker_native as well – If this issue affects the default worker, it likely also affects the native worker service which has a similar environment section. For consistency, the same comment could be added there too.

  2. Linking to documentation – If there's relevant documentation about running Windmill as non-root, adding a reference URL (similar to the security isolation comment above) would be helpful for users seeking more context.

No Issues Found

  • ✅ No bugs or logic issues (it's just a comment)
  • ✅ No security implications
  • ✅ No performance impact
  • ✅ Follows existing code style

Verification Instructions

This change adds documentation only. To verify: open the docker-compose.yml file and scroll to the windmill_worker service's environment section (around line 67-72) to confirm the new comment explaining the HOME=/tmp environment variable requirement for non-root deployments is present and clearly readable.

@cloudflare-workers-and-pages
Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3dc8511
Status: ✅  Deploy successful!
Preview URL: https://d3352705.windmill.pages.dev
Branch Preview URL: https://alp-doc-home.windmill.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants