Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security updates and style changes #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scones
Copy link

@scones scones commented Mar 15, 2020

No description provided.

@wind0r wind0r closed this Mar 15, 2020
@wind0r wind0r reopened this Mar 15, 2020
@wind0r
Copy link
Owner

wind0r commented Mar 15, 2020

I like that the default configuration is working with docker run -p 7396:7396 wind0r/folding-at-home and kubectl port-forward $POD_NAME 7396:7396

With this change everyone needs to overwrite the environment variables with the IP ranges they use or use --networking=host. This would create the helm and kubernetes config incompatible without in my opinion a security gain.

see: WARNING:Denied 1:172.17.0.1 access to URI: /

PS: Sorry for closing. Hit the wrong keyboard shortcut :)

@scones
Copy link
Author

scones commented Mar 17, 2020

odd, i thought for a second, it'd be a k8s repo, not a docker repo.

besides that. during local testing i found that the single quotes mess everything up. also i noticed a lack of even more variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants