Add jc package #932
Merged
Add jc package #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How the code works: from JSON take (via `grep -m1 -o`) the line "browser_download_url": "https://github.com/kellyjonbrazil/jc/releases/download/v1.23.6/jc_1.23.6-1_amd64.deb" 1. extract the matching key/value pair, excluding the final dquote. 2. remove everything upto and including the first dquote -> URL 3. from the URL, remove everything upto & including /download/v 4. then remove everything from '/' onwards -> version
philclifford
approved these changes
Nov 10, 2023
flexiondotorg
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides adding jc, this PR showcases a cleaner way to extract URL / version from the GH-release JSON file; the code is explained in the last commit. This method also cuts down on external shell calls (a single
grep, down from 5 external utility calls for most packages); the rest is done via shell string-ops.