add Joplin #1325
Open
add Joplin #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philclifford
requested changes
Feb 21, 2025
There was a problem hiding this comment.
This doesn't actually work:
[!] ERROR! Missing required information of github package joplin:
URL=
VERSION_PUBLISHED=
The CI install test "passes" but reading the log it should fail so is itself sadly broken.
Also please note the newer template in EXTREPO.md and recent package definitions and adopt the pattern of "grep -m1 " to avoid an extra head and "<<< ${URL}" to avoid unwanted extra echoes.
| DEFVER=1 | ||
| get_github_releases "laurent22/joplin" "latest" | ||
| if [ "${ACTION}" != "prettylist" ]; then | ||
| URL="$(grep "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | grep -v '.md5' | head -n1 | cut -d'"' -f4)" |
There was a problem hiding this comment.
Suggested change
| URL="$(grep "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | grep -v '.md5' | head -n1 | cut -d'"' -f4)" | |
| URL=$(grep -m1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4) |
| get_github_releases "laurent22/joplin" "latest" | ||
| if [ "${ACTION}" != "prettylist" ]; then | ||
| URL="$(grep "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | grep -v '.md5' | head -n1 | cut -d'"' -f4)" | ||
| VERSION_PUBLISHED="$(echo "${URL}" | cut -d'/' -f8 | sed "s/v//")" |
There was a problem hiding this comment.
Suggested change
| VERSION_PUBLISHED="$(echo "${URL}" | cut -d'/' -f8 | sed "s/v//")" | |
| VERSION_PUBLISHED=$( cut -d'/' -f8 <<<"${URL/v/}") |
Co-authored-by: Phil Clifford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New package joplin
this PR relates to #1303