Skip to content

rename deprecated lifecycle methods with UNSAFE_ prefix #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camflan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rename deprecated lifecycle methods with UNSAFE_ prefix #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/data-table/src/enhancers/withFiltering.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ function withFiltering(WrappedComponent, pureComponent = true) {
};
}

componentWillMount() {
UNSAFE_componentWillMount() {
if (this.state.filterText) {
this.handleChangeFilterText(this.state.filterText, this.props);
}
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (nextProps.dataList !== this.props.dataList) {
this.handleChangeFilterText(this.state.filterText, nextProps);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/data-table/src/enhancers/withSorting.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function withSorting(WrappedComponent, pureComponent = true) {
};
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (nextProps.dataList !== this.props.dataList) {
this.onSort(this.state, nextProps);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/event-flow/src/components/AggregatePanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class AggregatePanel extends React.PureComponent {
this.resetZoom();
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (Object.keys(nextProps).some(prop => nextProps[prop] !== this.props[prop])) {
this.resetZoom(nextProps);
this.setState({ ...AggregatePanel.clearedState() });
Expand Down
2 changes: 1 addition & 1 deletion packages/event-flow/src/components/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class App extends React.PureComponent {
};
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
const nextState = {};
if (this.props.data !== nextProps.data) {
const { alignByIndex, alignByEventType } = this.state;
Expand Down
2 changes: 1 addition & 1 deletion packages/event-flow/src/components/SingleSequencesPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class SingleSequencePanel extends React.PureComponent {
};
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (
nextProps.sequences &&
(this.props.sequences !== nextProps.sequences || this.width !== nextProps.width)
Expand Down
2 changes: 1 addition & 1 deletion packages/event-flow/src/components/Visualization.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Visualization extends React.PureComponent {
};
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
const updateProps = ['graph'];
if (updateProps.some(key => nextProps[key] !== this.props[key])) {
this.setState({
Expand Down
2 changes: 1 addition & 1 deletion packages/forms/src/StepIncrementer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class StepIncrementer extends React.Component {
};
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
const { value } = this.state;
const { value: nextValue } = nextProps;
if (nextValue !== value) {
Expand Down
2 changes: 1 addition & 1 deletion packages/histogram/src/chart/Histogram.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Histogram extends React.PureComponent {
this.state = this.getStateFromProps(props);
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
let shouldComputeBinsAndScales = false;
// eslint-disable-next-line react/destructuring-assignment
if (['width', 'height', 'children'].some(prop => this.props[prop] !== nextProps[prop])) {
Expand Down
2 changes: 1 addition & 1 deletion packages/network/src/chart/Network.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class Network extends React.PureComponent {
});
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
const {
graph,
animated,
Expand Down
2 changes: 1 addition & 1 deletion packages/sparkline/src/chart/Sparkline.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class Sparkline extends React.PureComponent {
this.state = this.getStateFromProps(props);
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (
[
// recompute scales if any of the following change
Expand Down
2 changes: 1 addition & 1 deletion packages/xy-chart/src/chart/Voronoi.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Voronoi extends React.PureComponent {
this.state = { voronoi: Voronoi.getVoronoi(props) };
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (
['data', 'x', 'y', 'width', 'height'].some(
prop => this.props[prop] !== nextProps[prop], // eslint-disable-line react/destructuring-assignment
Expand Down
2 changes: 1 addition & 1 deletion packages/xy-chart/src/chart/XYChart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class XYChart extends React.PureComponent {
}
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
let shouldComputeScales = false;
if (
['width', 'height', 'children'].some(
Expand Down
2 changes: 1 addition & 1 deletion packages/xy-chart/src/series/CirclePackSeries.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class CirclePackSeries extends React.PureComponent {
this.state = { data: this.computeCirclePack(props) };
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
// eslint-disable-next-line react/destructuring-assignment
if (['data', 'xScale', 'size'].some(prop => this.props[prop] !== nextProps[prop])) {
this.setState({ data: this.computeCirclePack(nextProps) });
Expand Down
2 changes: 1 addition & 1 deletion packages/xy-chart/src/utils/brush/Brush.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class Brush extends React.Component {
this.mouseDownTime = 0;
}

componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (
['width', 'height'].some(
prop => this.props[prop] !== nextProps[prop], // eslint-disable-line react/destructuring-assignment
Expand Down