[WIP] fix: ensure fallback locale is always loaded #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, when a fallback locale is defined, it isn't loaded automatically (as explained in #307).
That means you still have to specifically request that the fallback be loaded, which is inconvenient and often forgotten.
This commit updates the
getLocales()
method to ensure the fallback translations are always loaded when a fallback locale is defined.Here's a comparison in the case of a project with the
fr_CA
as the default locale andfr
as the fallback locale (with only one message, in order to keep things simple).Before:
After:
Closes #307