.toggleClass(boolean|undefined) is deprecated. #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 106 +1
Lines 635 651 +16
=========================================
+ Hits 635 651 +16
🚀 New features to boost your workflow:
|
|
-1 - should merge with no-class |
edg2s
changed the title
no-toggle-class; included in deprecated-3.0 with option
$x.toggleClass(false) which turns off all classes was deprecated in 3.0, and will be removed in 4. Other signatures are unaffected, so make this a separate rule to `no-class`.
|
The git commit title should be "New rule: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$x.toggleClass(false) which turns off all classes was deprecated
in 3.0, and will be removed in 4. Other signatures are unaffected,
so make this a separate rule to
no-class.