Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CreateMethodProperty with DefineMethodProperty #1391

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Replace CreateMethodProperty with DefineMethodProperty #1391

merged 1 commit into from
Mar 11, 2024

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Mar 11, 2024 •
edited by pr-preview bot
Loading

Fixes #1389

There's still 4 "review drafts" from 2023 that refer to CreateMethodProperty, but I assume those shouldn't be updated?

Preview | Diff

This was referenced Mar 11, 2024
Closed
Closed
@annevk annevk merged commit 5a2802b into whatwg:main Mar 11, 2024
2 checks passed
@annevk
Copy link
Member

annevk commented Mar 11, 2024

Thanks! And indeed, we try hard to avoid updating Review Drafts.

@ljharb ljharb deleted the DefineMethodProperty branch March 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateMethodProperty removed from Ecma262
2 participants
@ljharb @annevk