Fix all Bikeshed errors #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Jul 19, 2025
| spec:css-conditional-3; type:at-rule; text:@media | ||
| spec:css-display-3; type:value; for:display; text:flex | ||
| spec:css-flexbox-1; type:value; text:inline-flex | ||
| spec:css-syntax-3; type:dfn; text:invalid | ||
| spec:filter-effects-1; type:property; text:filter | ||
| spec:html; type:element; text:body | ||
| spec:infra; type:dfn; text:string |
There was a problem hiding this comment.
The new ambiguous string definition is breaking almost all WHATWG specs (and probably others too), so we should probably work to get the source spec updated to stop exporting it instead.
There was a problem hiding this comment.
I've decided to accept this for now, but I agree that this is a bad state to be in, but mostly for specifications not maintained by the WHATWG as they are not good about addressing warnings and errors.
There was a problem hiding this comment.
Yup, it's been fixed upstream in Bikeshed. Looks like the spec author actually did the right thing and avoided squatting on the word, but a ReSpec bug caused problems anyway. speced/respec#5007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes:
</code>on line 936Issue(87)to fail to parse on lines 558 and 592The first is a newly-detected bug. The fourth is normal linkrot as the autolinking database grows. The second and third shouldn't have ever worked; I'm confused how compat was building before. I've definitely not done anything recently for them.
With these, the spec builds clean.
Second commit isn't technically necessary, but it removes almost all of the anchors entries, in favor of either using link-defaults when necessary, or in a few places tweaking to use the correct autolink. (Sometimes nothing was necessary; autolinking worked just fine by default.) I've left the CSS3 Images entries, as they are intentionally linking to a very specific draft and need to be preserved as-is.
Preview | Diff