Extract better substrings #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find substrings in more cases, and allow a single regex to register multiple substrings.
dgrisby
commented
Sep 3, 2024
| def testAlternationCausesEmptyResult(self): | ||
| self.checkHints([], r"rum|grog") | ||
| def testAlternation(self): | ||
| self.checkHints({"rum", "grog"}, r"rum|grog") |
There was a problem hiding this comment.
This is one of the main improvements — an alternation can now make multiple index entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find substrings in more cases, and allow a single regex to register multiple substrings.
I did some analysis of how well the index was working for us, and found that for many regexes, it was unable to find anything to index. This greatly increases the coverage.