Short-circuit in NavGroup.get_active
#173
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing #172 I also noticed potential for a small performance improvement.
or
in thereturn
statement would short-circuit anyway regardless whether any of the items are active or notany
returnsTrue
on the first success we do not need the entire list. Using a generator saves us from evaluating the remainingget_active
calls. If any of the items has an expensive implementation ofget_active
we save ourselves from calling it.