Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add maxPieceLength option #267

Merged
merged 2 commits into from
Jan 4, 2025
Merged

feat: add maxPieceLength option #267

merged 2 commits into from
Jan 4, 2025

Conversation

SilentBot1
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR adds the new option maxPieceLength to provide an upper limit of what the automatic piece length calculation will be set to. This was requested in #266, as some clients run into issues with a pieceLength > 16M).

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

  • Should this also affect the pieceLength argument, or throw an error when both are used and pieceLength > maxPieceLength?

@SilentBot1 SilentBot1 merged commit 1264106 into master Jan 4, 2025
4 checks passed
@SilentBot1 SilentBot1 deleted the max-piece-size branch January 4, 2025 15:59
webtorrent-bot pushed a commit that referenced this pull request Jan 4, 2025
@semantic-release-bot
chore(release): 6.1.0
dcfa9ba 
# [6.1.0](v6.0.18...v6.1.0) (2025-01-04)

### Features

* add maxPieceLength option ([#267](#267)) ([1264106](1264106)), closes [#266](#266)
@webtorrent-bot
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaUnknown ThaUnknown ThaUnknown approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add maxPieceLength option
3 participants
@SilentBot1 @webtorrent-bot @ThaUnknown