Skip to content

feat: create a marketplace-link automatically when user submits to marketplace, and keep this link hidden in share link modal. #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victorchrollo14
Copy link
Contributor

Description

fixes: #4424

The approach to fix this goes as follows.

  1. create a share link with the name "wstd-marketplace-link" with view permission automatically when user submits for review.
  2. also delete the link when they unlist from marketplace.
  3. we are hiding this link in the share links modal, in order to prevent the user from getting confused about the link.
  4. we also prevent the user from creating a share link with the name 'wstd-marketplace-link' ( need to show some toast message maybe, right now only shows error ui )

But I don't get how the reject or approve process works, in order to add some stuff to delete the share link when the project get's rejected.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

… and prevent users from creating link with the marketplace-link name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share link for marketplace submissions isn't communicated well
1 participant