fix: modify ui to prevent social image name overflow in page settings. #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
kof
reviewed
Apr 4, 2025
| <Text variant={"labelsTitleCase"}> | ||
| {asset.meta.width} x {asset.meta.height} Px | ||
| </Text> | ||
| </Flex>{" "} |
kof
reviewed
Apr 4, 2025
| </Text> | ||
| <Grid | ||
| columns={1} | ||
| css={{ padding: theme.spacing[5], width: theme.spacing[34] }} |
There was a problem hiding this comment.
This area of code is old:
- I think you probably want theme.panel.padding
kof
reviewed
Apr 4, 2025
| > | ||
| <Grid flow={"column"} gap={1} align={"center"}> | ||
| <ImageIcon /> | ||
| <Text truncate css={{ width: 350 }} variant={"labelsTitleCase"}> |
There was a problem hiding this comment.
I think you want the layout to define the width without hardcoding
victorchrollo14
force-pushed
the
social-overflow-4953
branch
from
4c314ba to
f7b172d
Compare
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
|
hey @kof, seems like the same issue is present in marketplace image sections in page settings. shall I fix that as well and push it to this PR. |
|
Yes please! |
Hey @kof, sorry for the confusion. the same ImageInfo component is used in both the places, so this pr fixes overflow in both of these components. I was on the main branch earlier so got confused. |
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
victorchrollo14
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4953
aligned the name and other contents properly preventing long image names from overflowing out of view.
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile