Added StatusCodeError when receiving unexpected status code #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-airoldie
force-pushed
the
status_code_error
branch
from
47ee44d to
6a50bdc
Compare
jean-airoldie
force-pushed
the
status_code_error
branch
from
6a50bdc to
f1ad464
Compare
|
I'll include it when I release #222-based version which also breaks error handling in user code. |
|
On the second though, #236 is also technically unstabilizing ( |
|
Published |
|
@vi Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233.
While this is theoretically a breaking change, I'm unsure if its that significant.