Added method for writing multiple records together #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…batch This reduces additional overhead included in multiple write calls called for multiple records
…gether instead of compressing single record and concatening them
…ssed record just un-un-gzip-able
… massive blunders in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
write_warc_recordsmethod inWARCWriterand_write_warc_recordsmethod inBaseWARCWriterto write multiple records with a single write call.This reduces overheads with multiple write calls and makes the writing of multiple records faster.
Also I have not written any tests for the method but I have tested the method in my local system with Python 3.10.