Skip to content

Profile Saving Improvements #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2025
Merged

Profile Saving Improvements #894

merged 3 commits into from
Oct 9, 2025

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Oct 8, 2025

fix some observed errors that occur when saving profile:

  • use browser.cookies instead of page.cookies to get all cookies, not just from page
  • catch exception when clearing cache and ignore
  • logging: log when proxy init is happening on all paths, in case error in proxy connection

@ikreymer ikreymer requested a review from tw4l October 8, 2025 02:34
tw4l
tw4l approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, one comment to address before merging but approving so you can fix and merge

@ikreymer ikreymer merged commit 4f23404 into main Oct 9, 2025
4 checks passed
@ikreymer ikreymer deleted the profile-browser-cookies branch October 9, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tw4l tw4l tw4l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ikreymer @tw4l