Update screencast reported aspect ratio #794
Merged
+73
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
force-pushed
the
screencast-16-9-aspect-ratio
branch
from
537757d to
2604781
Compare
also adjust stylesheet in screencast html
ikreymer
force-pushed
the
screencast-16-9-aspect-ratio
branch
from
2604781 to
05b9be9
Compare
if setting GEOMETRY to 16x9, height will be adjusted
|
Updated to dynamically update the screencaster dimensions and html stylesheet. Keeping default as is, but running with, say |
ikreymer
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #793
Related to #733
Still hardcoded for the moment — maybe it should be updated to read from env variables? Let me know @ikreymer