Skip to content

feat(pages): add branding#120

Open
avivkeller wants to merge 2 commits into
mainfrom
branding
Open

feat(pages): add branding#120
avivkeller wants to merge 2 commits into
mainfrom
branding

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Jun 4, 2026

cc @webpack/tsc @rginn to approve the language used in this branding page. I'm not a lawyer. See https://webpack-doc-kit-git-branding-openjs.vercel.app/about/branding.

Copilot AI review requested due to automatic review settings June 4, 2026 16:25
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jun 4, 2026 4:32pm

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated branding page to the doc site and adjusts doc generation configuration to correctly resolve version-scoped site metadata during HTML generation.

Changes:

  • Added a new pages/about/branding.md page documenting webpack brand assets, colors, and trademark guidance (with links to OpenJS artwork and policy).
  • Simplified scripts/html/doc-kit.config.mjs input directory handling and fixed #theme/local/site import resolution for versioned builds.
  • Updated package-lock.json to reflect a lockfile regeneration/cleanup (removing some metadata and an extraneous entry).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
scripts/html/doc-kit.config.mjs Adjusts doc-kit path configuration and local site.json import resolution.
pages/about/branding.md Introduces the new branding/trademark guidelines page and asset references.
package-lock.json Lockfile cleanup/regeneration changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/html/doc-kit.config.mjs
Comment thread pages/about/branding.md
Comment thread pages/about/branding.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Comment thread pages/about/branding.md
Comment thread pages/about/branding.md
Comment on lines +154 to +160
webpack™ and the webpack logo are trademarks of the [OpenJS Foundation](https://openjsf.org/), which has registered trademarks and uses trademarks on behalf of its hosted projects. The webpack name and logos are **not** covered by the MIT license that governs the webpack source code.

Use of the webpack marks, including the name, logos, icons, and any confusingly similar variations thereof, is subject to the [OpenJS Foundation Trademark Policy](https://trademark-policy.openjsf.org/). Before using any webpack mark in a product name, service, domain name, publication, or other offering, please review the Trademark Policy and, where applicable, the [Trademark List](https://trademark-list.openjsf.org/) to ensure your intended use is permissible.

Nothing on this page grants, by implication, estoppel, or otherwise, any license or right to use any webpack mark except as expressly authorized by the OpenJS Foundation Trademark Policy. Unauthorized use of the marks, or use that creates a likelihood of confusion as to source, sponsorship, or affiliation, is strictly prohibited.

For a list of trademarks of the OpenJS Foundation, please see its [Trademark Policy](https://trademark-policy.openjsf.org/) page. Questions regarding trademark use may be directed to the OpenJS Foundation. All other trademarks are the property of their respective owners.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it simple and do what the other projects already do. Less is more, and that way we don't have to wait for Robin's approval. For any legal matters, there's already an email address in the Cross Project Council repository.

Suggested change
webpack™ and the webpack logo are trademarks of the [OpenJS Foundation](https://openjsf.org/), which has registered trademarks and uses trademarks on behalf of its hosted projects. The webpack name and logos are **not** covered by the MIT license that governs the webpack source code.
Use of the webpack marks, including the name, logos, icons, and any confusingly similar variations thereof, is subject to the [OpenJS Foundation Trademark Policy](https://trademark-policy.openjsf.org/). Before using any webpack mark in a product name, service, domain name, publication, or other offering, please review the Trademark Policy and, where applicable, the [Trademark List](https://trademark-list.openjsf.org/) to ensure your intended use is permissible.
Nothing on this page grants, by implication, estoppel, or otherwise, any license or right to use any webpack mark except as expressly authorized by the OpenJS Foundation Trademark Policy. Unauthorized use of the marks, or use that creates a likelihood of confusion as to source, sponsorship, or affiliation, is strictly prohibited.
For a list of trademarks of the OpenJS Foundation, please see its [Trademark Policy](https://trademark-policy.openjsf.org/) page. Questions regarding trademark use may be directed to the OpenJS Foundation. All other trademarks are the property of their respective owners.
Webpack is a project of the OpenJS Foundation. Please review the [trademark policy](https://trademark-policy.openjsf.org/) for information about permissible use of webpack™ logos and marks.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually remove this section entirely. The trademark information is already provided at the top.

Comment thread pages/about/branding.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did block this, but feel free to remove my block once the broken link is fixed, since the page would now be in a new location and the old page is https://webpack.js.org/branding/. There's really no need to change the existing URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branding Page

3 participants