feat(pages): add branding#120
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a dedicated branding page to the doc site and adjusts doc generation configuration to correctly resolve version-scoped site metadata during HTML generation.
Changes:
- Added a new
pages/about/branding.mdpage documenting webpack brand assets, colors, and trademark guidance (with links to OpenJS artwork and policy). - Simplified
scripts/html/doc-kit.config.mjsinput directory handling and fixed#theme/local/siteimport resolution for versioned builds. - Updated
package-lock.jsonto reflect a lockfile regeneration/cleanup (removing some metadata and an extraneous entry).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/html/doc-kit.config.mjs | Adjusts doc-kit path configuration and local site.json import resolution. |
| pages/about/branding.md | Introduces the new branding/trademark guidelines page and asset references. |
| package-lock.json | Lockfile cleanup/regeneration changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| webpack™ and the webpack logo are trademarks of the [OpenJS Foundation](https://openjsf.org/), which has registered trademarks and uses trademarks on behalf of its hosted projects. The webpack name and logos are **not** covered by the MIT license that governs the webpack source code. | ||
|
|
||
| Use of the webpack marks, including the name, logos, icons, and any confusingly similar variations thereof, is subject to the [OpenJS Foundation Trademark Policy](https://trademark-policy.openjsf.org/). Before using any webpack mark in a product name, service, domain name, publication, or other offering, please review the Trademark Policy and, where applicable, the [Trademark List](https://trademark-list.openjsf.org/) to ensure your intended use is permissible. | ||
|
|
||
| Nothing on this page grants, by implication, estoppel, or otherwise, any license or right to use any webpack mark except as expressly authorized by the OpenJS Foundation Trademark Policy. Unauthorized use of the marks, or use that creates a likelihood of confusion as to source, sponsorship, or affiliation, is strictly prohibited. | ||
|
|
||
| For a list of trademarks of the OpenJS Foundation, please see its [Trademark Policy](https://trademark-policy.openjsf.org/) page. Questions regarding trademark use may be directed to the OpenJS Foundation. All other trademarks are the property of their respective owners. |
There was a problem hiding this comment.
Keep it simple and do what the other projects already do. Less is more, and that way we don't have to wait for Robin's approval. For any legal matters, there's already an email address in the Cross Project Council repository.
| webpack™ and the webpack logo are trademarks of the [OpenJS Foundation](https://openjsf.org/), which has registered trademarks and uses trademarks on behalf of its hosted projects. The webpack name and logos are **not** covered by the MIT license that governs the webpack source code. | |
| Use of the webpack marks, including the name, logos, icons, and any confusingly similar variations thereof, is subject to the [OpenJS Foundation Trademark Policy](https://trademark-policy.openjsf.org/). Before using any webpack mark in a product name, service, domain name, publication, or other offering, please review the Trademark Policy and, where applicable, the [Trademark List](https://trademark-list.openjsf.org/) to ensure your intended use is permissible. | |
| Nothing on this page grants, by implication, estoppel, or otherwise, any license or right to use any webpack mark except as expressly authorized by the OpenJS Foundation Trademark Policy. Unauthorized use of the marks, or use that creates a likelihood of confusion as to source, sponsorship, or affiliation, is strictly prohibited. | |
| For a list of trademarks of the OpenJS Foundation, please see its [Trademark Policy](https://trademark-policy.openjsf.org/) page. Questions regarding trademark use may be directed to the OpenJS Foundation. All other trademarks are the property of their respective owners. | |
| Webpack is a project of the OpenJS Foundation. Please review the [trademark policy](https://trademark-policy.openjsf.org/) for information about permissible use of webpack™ logos and marks. |
There was a problem hiding this comment.
I'd actually remove this section entirely. The trademark information is already provided at the top.
There was a problem hiding this comment.
I did block this, but feel free to remove my block once the broken link is fixed, since the page would now be in a new location and the old page is https://webpack.js.org/branding/. There's really no need to change the existing URL.
cc @webpack/tsc @rginn to approve the language used in this branding page. I'm not a lawyer. See https://webpack-doc-kit-git-branding-openjs.vercel.app/about/branding.