Conversation
chore(deps-dev): bump webpack-dev-server from 5.0.2 to 5.0.3 (webpack#4108)
|
Here is the rebase version an existing pull request I had made regarding autocomplete feature as said by sir @evenstensberg. Had to close the previous pr. I would love to take on this issue again if possible. Best. |
|
There's still conflicts |
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Super. We're going to review this pr multiple times. When we suggest a change, do the change and then we iterate.
Thanks for your contribution! <3
| @@ -0,0 +1,152 @@ | |||
| import * as Fs from "fs"; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
I think there is some work still pending, one important thing is to find a way to fetch list of all the commands supported by webpack-cli to display on auto complete. I'm ready to take on this issue once again but this issue still I can't figure out how to fix. |
|
Could you create a todo in the pr description so we can see what you think is missing? |
|
I'll update you soon |
| } else if (isCommand(commandName, getKnownCommand("setup-autocomplete"))) { | ||
| this.makeCommand(getKnownCommand("setup-autocomplete"), [], async () => { | ||
| await this.setupAutocompleteForShell(); | ||
| }); |
There was a problem hiding this comment.
We should use commander api here, get all commands and options and run setupAutocompleteForShell with them
|
This is a good pr, thanks for working on this. We're closing outdated PRs, so feel free to submit another one and we can have a look ❤️ |
4 participants
What kind of change does this PR introduce?
feature #1402
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information