Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2887 +/- ##
==========================================
- Coverage 94.96% 94.93% -0.03%
==========================================
Files 31 31
Lines 1708 1718 +10
Branches 486 486
==========================================
+ Hits 1622 1631 +9
- Misses 86 87 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
alexander-akait
left a comment
There was a problem hiding this comment.
Let's add test for this, looks good
rishabh3112
left a comment
There was a problem hiding this comment.
Looks good. For testing it, you may add a case in serve's smoketest only.
|
I am not sure how to mock |
|
Just run process using |
| }); | ||
|
|
||
| // TODO: fix for windows | ||
| if (isWindows) { |
There was a problem hiding this comment.
I think it is not good to skip windows test here...
There was a problem hiding this comment.
I will see if I can test it on a windows machine locally.
|
@snitin315 let's rebase, I think it is finished and please don't ignore windows tests, I will fix it if it will have problems |
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
NO
Summary
Does this PR introduce a breaking change?
No
Other information
NO