Conversation
bjohansebas
approved these changes
Jan 26, 2026
Member
Author
|
Still WIP, there are more them |
alexander-akait
commented
Jan 26, 2026
| @@ -1,5 +1,3 @@ | |||
| @value toggleTime: 200ms; | |||
Member
Author
There was a problem hiding this comment.
No need to use postcss-icss-values for the only one value, if we want in future to have variables, better to use CSS custom properties
alexander-akait
commented
Jan 26, 2026
| const path = require("path"); | ||
| const { readFileSync } = require("fs"); | ||
| const globby = require("globby"); | ||
| const { globSync } = require("tinyglobby"); |
Member
Author
There was a problem hiding this comment.
tinyglobby has less deps
alexander-akait
commented
Jan 26, 2026
| "autoprefixer": "10.2.5", | ||
| "babel-eslint": "10.1.0", | ||
| "babel-loader": "9.2.1", | ||
| "babel-plugin-lodash": "3.3.4", |
Member
Author
There was a problem hiding this comment.
We don't use lodash at all right now, so we don't need outdated plugin
Member
Author
|
@valscion ready to review, the next steps:
After this we can make a new releases with our new code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reduce unnecessary deps
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing