Calculate penalty expiration based on event date instead of current date #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falbru
force-pushed
the
change-penalty-expiration-date
branch
from
ce47a83 to
dc95e8e
Compare
Contributor
Author
|
This should probably get fixed when the new penalty rules get merged, so not that important to merge |
ivarnakken
approved these changes
Mar 10, 2024
Member
ivarnakken
left a comment
ivarnakken
left a comment
There was a problem hiding this comment.
Yes this makes more sense 👍🏼
Bestem0r
approved these changes
Mar 11, 2024
ivarnakken
added
approved
falbru
force-pushed
the
change-penalty-expiration-date
branch
3 times, most recently
from
f9d3103 to
617ede8
Compare
falbru
force-pushed
the
change-penalty-expiration-date
branch
from
617ede8 to
59c288d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just makes sense in my opinion. A few incidents have happened where a penalty weight has to be changed or a penalty being deleted by accident has to be added again. When the penalty is added again, the expiration date would be later since it is calculated based on when it was created instead of the event date.
after:
I made these penalties at the same time