Skip to content

Use GPUBuffer in GPUBindingResource #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented May 22, 2025

@beaufortfrancois beaufortfrancois marked this pull request as draft May 22, 2025 08:29
@beaufortfrancois
Copy link
Collaborator Author

FYI It requires gpuweb/types#182

@beaufortfrancois beaufortfrancois marked this pull request as ready for review May 28, 2025 09:35
@beaufortfrancois beaufortfrancois requested a review from greggman May 28, 2025 09:37
@kainino0x kainino0x marked this pull request as draft June 3, 2025 21:27
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but marking draft as we need to wait until all browsers support this.

@greggman
Copy link
Collaborator

greggman commented Jun 3, 2025

Thanks for this PR. I like this new style!

Agree with @kainino0x, we shouldn't merge this until all browsers support it and it's shipped in Chrome stable, and maybe given it 2+ weeks or after that.

@beaufortfrancois
Copy link
Collaborator Author

FYI @jimblandy @mwyrzykowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants