-
Notifications
You must be signed in to change notification settings - Fork 61
feat(cc-widgets): multi party conference #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...cc-components/src/components/task/CallControl/CallControlCustom/call-control-custom.utils.ts
Outdated
Show resolved
Hide resolved
...cc-components/src/components/task/CallControl/CallControlCustom/call-control-custom.utils.ts
Outdated
Show resolved
Hide resolved
...cc-components/src/components/task/CallControl/CallControlCustom/call-control-custom.utils.ts
Show resolved
Hide resolved
...cc-components/src/components/task/CallControl/CallControlCustom/consult-transfer-popover.tsx
Show resolved
Hide resolved
packages/contact-center/cc-components/src/components/task/CallControl/call-control.utils.ts
Show resolved
Hide resolved
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
adhmenon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not reviewed tests but core code is looking good. Flows are all fine.
Have few doubts - but other than that, let us test once more and then the PR should be alright.
...cc-components/src/components/task/CallControl/CallControlCustom/consult-transfer-popover.tsx
Show resolved
Hide resolved
packages/contact-center/cc-components/src/components/task/CallControlCAD/call-control-cad.tsx
Show resolved
Hide resolved
...-components/tests/components/task/CallControl/CallControlCustom/call-control-custom.util.tsx
Outdated
Show resolved
Hide resolved
rarajes2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have done first round of review, will require multiple rounds of review as the changes are big.
...ter/cc-components/src/components/task/CallControl/CallControlCustom/call-control-consult.tsx
Outdated
Show resolved
Hide resolved
...cc-components/src/components/task/CallControl/CallControlCustom/call-control-custom.utils.ts
Outdated
Show resolved
Hide resolved
...cc-components/src/components/task/CallControl/CallControlCustom/call-control-custom.utils.ts
Outdated
Show resolved
Hide resolved
...cc-components/src/components/task/CallControl/CallControlCustom/call-control-custom.utils.ts
Outdated
Show resolved
Hide resolved
| onDialNumberSelect: ((dialNumber: string, allowParticipantsToInteract: boolean) => void) | undefined, | ||
| onEntryPointSelect: | ||
| | ((entryPointId: string, entryPointName: string, allowParticipantsToInteract: boolean) => void) | ||
| | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the ? with variable instead of defining type undefined like this. Applicable everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
as rajesh and adhwaith reviewing this now.
rarajes2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, rest looks good to me. We should create a ticket for corner cases that we are going to handle in next ticket.
Please address last few comments and create JIRA before merging the PR.
# [1.28.0-ccwidgets.123](v1.28.0-ccwidgets.122...v1.28.0-ccwidgets.123) (2025-11-11) ### Features * **cc-widgets:** multi party conference ([#539](#539)) ([f2a23d4](f2a23d4))
|
🎉 This PR is included in version 1.28.0-ccwidgets.123 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7183
This pull request addresses
Implemented the Multi-Party Conference feature supporting more than three participants, along with the Conference Transfer functionality.
Conference Transfer Behavior:
An agent can initiate a transfer only during a consultation.
Scenario 1: If Agent A1 and Agent A2 are on a consultation while the customer is on hold, upon transfer, A1 leaves and A2 takes ownership of the call.
Scenario 2: If Agent A1 and Agent A3 are on a consultation while the customer and Agent A2 are already in the main conference, upon transfer, A1 leaves, A2 becomes the new owner, and A3 joins the main conference with A2 and the customer.
by making the following changes
Added new buttons for Conference and Exit Conference and added handling of those buttons
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging