feat(callsettings): add Fedramp support for callsettings #4582
+189
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As discussed please add sample app changes to call this init in sample app |
Contributor
Author
|
rsarika
approved these changes
Nov 28, 2025
Shreyas281299
requested changes
Dec 1, 2025
| async function getCallForwardAlwaysSetting() { | ||
| if (window.callSettings === undefined) { | ||
| callSettings = window.callSettings = CreateCallSettingsClient(webex, logger, enableProd); | ||
| await callSettings.init(); |
Contributor
There was a problem hiding this comment.
I dont think this is required. CreateCallSettingsClient does everything.
Comment on lines
+83
to
+85
| public async init(): Promise<void> { | ||
| // No initialization required for WxCall backend | ||
| return Promise.resolve(); |
| * Initialize the connector by setting up auth headers. | ||
| */ | ||
| public async init() { | ||
| this.authHeaders = await this.getAuthHeaders(); |
Contributor
There was a problem hiding this comment.
This can be done where we are using this authHeaders, introducing a new init method just for this seems an overkill
| /** | ||
| * Initializes the call settings service. | ||
| */ | ||
| public async init(): Promise<void> { |
Contributor
There was a problem hiding this comment.
I think we can avoid doing this.
- in UcmBackeendConnector you can get the authHeader when we call the method
- in WxCallBackendConncetor init is an empty resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-735619>
This pull request addresses
Add FedRAMP government compliance support to CallSettings client with dynamic URL switching, authorization headers, and async initialization pattern.
Add comprehensive unit tests for FedRAMP functionality
by making the following changes
This enables CallSettings to work in FedRAMP/government environments by:
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.