Skip to content

Conversation

WeijuanShao
Copy link
Contributor

COMPLETES # https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-478810

This pull request addresses

To fix issue that host/cohost can't change meeting options In Breakout. Check the spec document of it, the host/cohost want to change meeting options, need to use main locus url as request url and the breakout url as an parameter "authorizingLocusUrl"

by making the following changes

Cache the mainLocusUrl in controls-options-manager
Use the mainLocusUrl and locusUrl as authorizingLocusUrl into request body if they are differenct

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@WeijuanShao WeijuanShao requested review from a team as code owners October 15, 2025 06:19
@JudyZhuHz JudyZhuHz added the validated If the pull request is validated for automation. label Oct 16, 2025
Copy link
Contributor

@JudyZhuHz JudyZhuHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants