fix(contact-center): add behavioral events for outdial ani ep metrics #4537
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
|
||
| const product: MetricEventProduct = PRODUCT_NAME; | ||
|
|
||
| const createTaxonomyObjForUserSuccess = (target: string): BehavioralEventTaxonomy => { |
There was a problem hiding this comment.
Can we use them directly since they are only being used once? There's no need for a separate method, and we should maintain consistency with other events. Is there a reusability factor that I'm overlooking?
There was a problem hiding this comment.
the idea was that this function can be reused for all the user success events rather than having to duplicate objects repeatedly
| }, | ||
|
|
||
| // Outdial ANI API Events | ||
| [METRIC_EVENT_NAMES.OUTDIAL_ANI_EP_FETCH_SUCCESS]: |
There was a problem hiding this comment.
can we use directly like below
product,
agent: 'user',
target: 'outdial_ani_ep_fetch',
verb: 'complete',
},
to maintain consistancy?
There was a problem hiding this comment.
sure we could but imo the rest of the events should be refactored to use functions to stop all this duplication and keep the code dry
- adds outdial aini events metrics to behavioral events - adds helper function to create event objects to reduce code duplication
3 participants
COMPLETES # CAI-7180
This pull request addresses
by making the following changes
Vidcast: https://app.vidcast.io/share/d2f13b5b-bf9d-4fa2-b0e1-cdd0ca2c4b73
Change Type
The following scenarios were tested
tested manually
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.