Skip to content

Conversation

oleksiijko
Copy link
Contributor

@oleksiijko oleksiijko commented Oct 10, 2025

COMPLETES WEBEX-447557

This pull request addresses

When user stop vide, source state is live every time

by making the following changes

When user stop vide, source state changed from live to no source

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

Test it manually, on sample app click stop video button and check source state

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@oleksiijko oleksiijko requested review from a team as code owners October 10, 2025 08:18
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4526.d3m3l2kee0btzx.amplifyapp.com

Copy link
Contributor

@edvujic edvujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the most correct way of handling this. I think we probably need additional buttons like Unpublish Camera Stream and Unpublish Audio Stream. I don't think that we should unpublish the camera/video stream every time we mute the camera. I presume that this would mean that we unrequest/request the stream every time we mute the audio/video? Or am I missing something? Maybe @antsukanova has a better notion of the SDK sample app, so I would be interested in her comments.

Comment on lines 1567 to 1569
if (localMedia.cameraStream) {
await meeting.unpublishStreams([localMedia.cameraStream]);
localMedia.cameraStream.stop();
Copy link
Contributor

@edvujic edvujic Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be after we stop the camera stream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, because have error with localMedia.cameraStream if was another order

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the order here is right, we won't be able to `stop` cameraStream and then `unpublishStreams`, but should we also check that meeting exists? What will happen if the meeting does not exist? And I beliebe you need to do `const meeting = getCurrentMeeting();` after `if (localMedia.cameraStream) {`

Copy link
Contributor

@edvujic edvujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please populate the PR description correctly.
image

@edvujic edvujic added the validated If the pull request is validated for automation. label Oct 10, 2025
@oleksiijko oleksiijko changed the title feat: add unpublishStream on video stop in sample app fix: add unpublishStream on video stop in sample app Oct 20, 2025
@oleksiijko oleksiijko changed the title fix: add unpublishStream on video stop in sample app chore: add unpublishStream on video stop in sample app Oct 20, 2025
"deploy:npm": "yarn npm publish"
},
"dependencies": {
"@webex/internal-media-core": "2.18.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be as separate PR change.

Copy link
Contributor

@antsukanova antsukanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants