-
Notifications
You must be signed in to change notification settings - Fork 384
fix: add socket error and metrics #4521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Just 1-2 minor comments
packages/@webex/contact-center/test/unit/spec/services/task/index.ts
Outdated
Show resolved
Hide resolved
|
||
// Track successful Mercury connection | ||
this.metricsManager.trackEvent( | ||
METRIC_EVENT_NAMES.WEBSOCKET_REGISTER_SUCCESS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an open question - should we track mercury metrics along with the other regular websocket metric events?
Or should we have a separate metric for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought this is specifc to the contact center socket and has nothing to do with mercury, calling one is different not sure how they would work here
Small PR to add error metrics for socket
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.