feat(SPARK-697640): support New HTTP Header X-Cisco-Part-Route-Token #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
packages/@webex/plugin-meetings/src/interceptors/locusRouteToken.ts
Outdated
Show resolved
Hide resolved
| return this.webex.meetings.meetingCollection.getActiveWebrtcMeeting()?.id; | ||
| getLocusIdByRequestUrl(url: string) { | ||
| if (url) { | ||
| return url.match(/\/loci\/([a-f0-9-]{36})/i)?.[1]; |
There was a problem hiding this comment.
maybe it would be safer to match the bigger string "locus/api/v1/loci" not just "loci"
There was a problem hiding this comment.
Thanks! I'have updated the regex.
marcin-bazyl
added
the
validated
marcin-bazyl
approved these changes
Oct 15, 2025
JudyZhuHz
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-697640 >
This pull request addresses
support New HTTP Header
by making the following changes
add X-Cisco-Part-Route-Token in plugin-meetings interceptor
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.