Skip to content

Fix byova common proto import #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix byova common proto import #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ices/VoiceVirtualAgent/5397013b-7920-4ffc-807c-e8a3e0a18f43/Proto/voicevirtualagent.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ These definitions will be used for communication between client and VA(server) o
syntax = "proto3";
package com.cisco.wcc.ccai.media.v1;

import "byova_common.proto";
import "com/cisco/wcc/ccai/media/v1/common/byova_common.proto";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wont build hence we purposely removed full path from import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could work here because these two protos are in same directory but while using these protos in dialog-connector-simulator, it will fail because voicevirtualagent.proto will look for byova_common.proto in the same directory and it won't be available in that directory because package is different.

attached compilation logs if we use "import "byova_common.proto"
proto-compilation-error.log

import "google/protobuf/timestamp.proto";
import "google/protobuf/struct.proto";

Expand Down