Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(README.md): fix links #800

Merged
merged 3 commits into from
Mar 31, 2025
Merged

chore(README.md): fix links #800

merged 3 commits into from
Mar 31, 2025

Conversation

Delta456
Copy link
Contributor

Links FAQs to the new link and corrects the file path

Fixes webdriverio/webdriverio#14345

@Delta456
chore(README.md): fix links
eb6f662 
Links FAQs to the new link and corrects the file path
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 496a552

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

alcpereira
alcpereira reviewed Mar 31, 2025
View reviewed changes
README.md
@@ -514,7 +514,7 @@ Please join our [Discord](https://discord.webdriver.io) Server if you have any q

### Issues

If you have questions, bugs or feature requests, please file an issue. Before submitting an issue, please search the issue archive to help reduce duplicates, and read the [FAQ](../README.md#faq).
If you have questions, bugs or feature requests, please file an issue. Before submitting an issue, please search the issue archive to help reduce duplicates, and read the [FAQ](https://webdriver.io/docs/visual-testing/faq/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit tricky as this file is currently compiled by the official wdio docs into this page.

@wswebcreation any suggestion on how to improve this? I guess in the future this won't be the case anymore, so maybe we accept this change and later fix it with a proper path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a path for this then we can do it right now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the readme is "messed" up. I'll go ahead and merge this and fix it.

Thanks @Delta456

wswebcreation
wswebcreation approved these changes Mar 31, 2025
View reviewed changes
README.md
@@ -514,7 +514,7 @@ Please join our [Discord](https://discord.webdriver.io) Server if you have any q

### Issues

If you have questions, bugs or feature requests, please file an issue. Before submitting an issue, please search the issue archive to help reduce duplicates, and read the [FAQ](../README.md#faq).
If you have questions, bugs or feature requests, please file an issue. Before submitting an issue, please search the issue archive to help reduce duplicates, and read the [FAQ](https://webdriver.io/docs/visual-testing/faq/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the readme is "messed" up. I'll go ahead and merge this and fix it.

Thanks @Delta456

@wswebcreation wswebcreation merged commit 69c0c8b into webdriverio:main Mar 31, 2025
11 checks passed
@wdio-bot
Copy link
Contributor

Hey Delta456 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@Delta456 Delta456 deleted the patch-1 branch March 31, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcpereira alcpereira alcpereira left review comments

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
Expensable $5 💸
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Documentation - Services - Image Comparison Broken links
4 participants
@Delta456 @wdio-bot @wswebcreation @alcpereira