Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ws/fix-747-improve-mobile-webview-screenshot #777

Merged
merged 32 commits into from
Apr 5, 2025
Merged

Ws/fix-747-improve-mobile-webview-screenshot #777

merged 32 commits into from
Apr 5, 2025

Conversation

wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented Mar 15, 2025 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 48ffabc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wswebcreation
feat: initial setup for device layer calculations
4722216 
- this is work in progress
@wswebcreation
chore: fixed some stuff and updated some broken UT's
867ee1b
@wswebcreation
fix: right import and export
ccb3609
@wswebcreation
fix: fix mocks
26fbf99
@wswebcreation
chore: optimise code a bit and add docs
bcaeaa4
@wswebcreation
chore: fix linking and types
f533196
@wswebcreation
fix: fix return data from overlay
ce869d9
@wswebcreation
feat: add Android support for blockouts based on device rectangles
ade0343
@wswebcreation
feat: support ios and android for checkScreen
1afd8b3 
- simplify determineStatusAddressToolBarRectangles
- reduce rectangle tests
- fix data url loading in Safari
@wswebcreation
feat: add checkElement support
bd1cbd8
@wswebcreation
fix: optimise code and fix UTs for element
dc9a3fb
@wswebcreation
feat: support savefullpagescreenshot with new viewport data for Android
14731c4
@wswebcreation
feat: support fullpage for iOS portrait
1c6ebee
@wswebcreation
test: fix tests
bfab8c2
@wswebcreation
fix: multiple fixes for fullpage
5d46b3b 
- iOS had issues on landscape
- removed not needed code and files
@wswebcreation
chore: remove logs
a32e458
@wswebcreation
fix: fix Android Appium 1 issues
311794d 
- add fallback
- remove logs
- update images for android phones
@wswebcreation
chore: update iOS stuff
fa0537c 
- add LANDSCAPE for local android
@wswebcreation
chore: updated safari desktop screenshots
9e5f7b9
@wswebcreation
Merge branch 'main' into ws/fix-747-improve-mobile-webview-screenshot
a67b457
@wswebcreation
test: update snapshots
bcb31d5
@wswebcreation
Merge branch 'main' into ws/fix-747-improve-mobile-webview-screenshot
6cb30b6
@wswebcreation
feat: move the new logic to the webdriver-image-comparison module
f6b0713
@wswebcreation
fix: fix unit tests
37d2244
@wswebcreation
breaking: taking element screenshot for iOS
099ab9f 
- some other small fixes
@wswebcreation
chore: optimise deviceRectangles
4c49179 
- remove devicePlatformRect
- enrich deviceRectangles with statusBar and homeBar
- change devicePlatformRect output to x/y instead of left/top to match a coordinate system
- fix UTs
@wswebcreation
chore: refactor stuff
c87255b 
- rename function
- add screendata for deviceRectangles
@wswebcreation wswebcreation changed the base branch from main to ws/new-major-releases March 30, 2025 11:45
@wswebcreation wswebcreation marked this pull request as ready for review April 5, 2025 05:39
@wswebcreation wswebcreation merged commit 002c45d into ws/new-major-releases Apr 5, 2025
16 of 19 checks passed
@wswebcreation wswebcreation deleted the ws/fix-747-improve-mobile-webview-screenshot branch April 5, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome and Android 15 give incorrect viewport data
1 participant
@wswebcreation