Skip to content

Dev #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

Dev #54

merged 4 commits into from
May 12, 2025

Conversation

webdevnerdstuff
Copy link
Owner

No description provided.

@webdevnerdstuff webdevnerdstuff self-assigned this May 12, 2025
@webdevnerdstuff webdevnerdstuff requested a review from Copilot May 12, 2025 20:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR contains various updates to Vue component files, TypeScript interfaces, and template props to improve consistency and type safety as well as to remove deprecated or unused props. Key changes include:

  • Updating the FieldLabel component’s prop interface for a more concise optional definition.
  • Refining the type handling in the VSFButtonField component.
  • Removing the :codeBlockSettings prop in several documentation example components and updating the DocsPage usage.
  • Adding a Props interface for the open prop in multiple documentation examples for consistency.
  • Introducing defineOptions in ExampleContainer.vue to disable attribute inheritance.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/plugin/components/shared/FieldLabel.vue Simplified TS interface for the required property.
src/plugin/components/fields/VSFButtonField/VSFButtonField.vue Enhanced type handling in getId and isActive functions.
src/documentation/sections/ExampleSection.vue Removed :codeBlockSettings prop from ExampleContainer usage.
src/documentation/components/examples/* Added a Props interface to define an optional open prop consistently.
src/documentation/components/ExampleContainer.vue Added defineOptions to disable inherited attributes.
src/App.vue Removed passing codeBlockOptions to DocsPage.

@webdevnerdstuff webdevnerdstuff merged commit 1ecbd7f into main May 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant