Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new mobs and entity classes in 1.11 #15

Merged
merged 1 commit into from
Mar 18, 2017
Merged

Update for new mobs and entity classes in 1.11 #15

merged 1 commit into from
Mar 18, 2017

Conversation

KovuTheHusky
Copy link
Contributor

Entity classes were cleaned up for 1.11 and sub-entities were put into their own classes. I've also added mobs such as the Evoker, Vex, and Vindicator.

I also updated the icon for vanillahorse and various minecarts.

@KovuTheHusky
Copy link
Contributor Author

This also closes #14.

@KovuTheHusky
Copy link
Contributor Author

KovuTheHusky commented Feb 16, 2017

It may be better to simply use the entity name ("savegame ID") if that is at all possible due to issues with inheritance, such as #9. That would require a rewrite though. Is there any technical reason this isn't a possibility? If not, I'd gladly look into it in my free time. Thanks!

@wioxjk
Copy link

wioxjk commented Mar 14, 2017

@mikeprimm
Can you please merge this?

@wioxjk
Copy link

wioxjk commented Mar 17, 2017

@KovuTheHusky
Is it possible that you can compile the .jar and post it somewhere? Would be nice with an up-to-date plugin to dynmap :)

@KovuTheHusky
Copy link
Contributor Author

The best thing would be for @mikeprimm to accept this PR - it's his project after all. If you want an up to date jar for now you should be able to clone the repo and run mvn install to make your own. I don't want to overstep and start distributing it myself.

@wioxjk
Copy link

wioxjk commented Mar 18, 2017

@KovuTheHusky
Well, I know that @mikeprimm ranted about that noone helped him in this project a few month ago. And when someone takes the time to improve - nothing happends.

I am not familliar with "nvm" actually, I guess it is just to run it in the catalogue?

@mikeprimm mikeprimm merged commit 2e37810 into webbukkit:master Mar 18, 2017
@mikeprimm
Copy link
Member

@KovuTheHusky Thanks for the update, as always
@wioxjk The 'rant' was about the presumptuousness of an over-entitled prick who seems to think that someone who has donated literally thousands of hours of development time over the past 6 years for no pay to produce mods that have always been available for free owes him ANYTHING (hint: I don't). You don't get to get things for free and then complain about them not being what you want - particularly when their source is available for free, and you're able to make what you want yourself (given suitable time, talent, and motivation).

@wioxjk
Copy link

wioxjk commented Mar 19, 2017

@mikeprimm
I totally agree with you! I do not know how many hours you have spent to make dynmap and all the plugins to it - but it is propably alot! And that kids attitude was not the best.
But I mean, @KovuTheHusky wanted to merge his update over a month ago. That is a pretty long time...

Anyway, thanks for the merge!

@KovuTheHusky KovuTheHusky deleted the 1.11-entity-ids branch May 23, 2017 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants