This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add karma & chrome/firefox headless browser fixtures #3146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
commented
Oct 20, 2019
cgewecke
commented
Oct 20, 2019
cgewecke
commented
Oct 20, 2019
9 tasks
nivida
suggested changes
Oct 21, 2019
|
@nivida Made requested changes, thanks for reviewing. |
nivida
approved these changes
Oct 22, 2019
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Add karma & chrome/firefox headless browser fixtures * Add test helper for conditional web3 require * Add websocket port test helper * Move build/lint to their own CI job * Fix package-lock from rebase * Fix ci.sh * Skip all websockets tests for geth.instamine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3098
packages/web3/dist/web3.min.jsThere are various ways of setting this up. phantomjs is deprecated now fwiw.
Picked karma because it's well supported by Google/Angular, runs mocha tests easily, has lots of plugins, stack-overflow/github help, and should be low-maintenance.
Reference Documentation