-
Notifications
You must be signed in to change notification settings - Fork 4
Add Demonstration React Template #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6dbb961
to
916b3b3
Compare
916b3b3
to
d0e1b9b
Compare
|
This is another thing that was inherited from |
Nope sorry this is wrong - https://github.com/facebook/create-react-app/blob/main/packages/cra-template-typescript/template/src/App.css |
Hey, great PR! I was just wondering if it might also be valuable to show how devs can switch chains using web3js. Personally, I use the Rabby Wallet, which hides the chain selection from the user and lets the dApp decide which chain to use. However, I’ve noticed the demo dApp in this PR only works with chainID 1 when using Rabby. |
Yes this is a great suggestion but I don't think it fits into this demonstration template at this time. Today in the Web3.js plugin meeting we talked about this Issue, which seems very related web3/web3.js#6946 |
Refer to the documentation for additional details.