Initial Commit for create-web3js-dapp #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
reviewed
Sep 20, 2024
src/index.ts
Outdated
| } | ||
| } | ||
|
|
||
| cpSync(src, join(process.cwd(), dst), { recursive: true }); |
There was a problem hiding this comment.
I'll suggest to wrap the cpSync() call in a try-catch block to handle/display any errors that may occur during the copying process & specially for displaying feedback message on successful/unsuccessful completion.
danforbes
force-pushed
the
feat/cli/init
branch
2 times, most recently
from
f6125f3 to
46e6050
Compare
danforbes
force-pushed
the
feat/cli/init
branch
from
46e6050 to
9f85733
Compare
danforbes
force-pushed
the
feat/cli/init
branch
from
9f85733 to
8f256cf
Compare
danforbes
requested review from
avkos,
Muhammad-Altabba,
luu-alex and
jdevcs
avkos
approved these changes
Sep 23, 2024
jdevcs
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6