Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test for dynamic CSP with new preload behavior #50204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update test for dynamic CSP with new preload behavior #50204

wants to merge 2 commits into from

Conversation

nidhijaju
Copy link
Member

This aligns with the proposal in whatwg/fetch#1803.

@nidhijaju nidhijaju requested a review from noamr January 22, 2025 02:53
@nidhijaju nidhijaju mentioned this pull request Jan 22, 2025
Open
3 tasks
@yoavweiss
Copy link
Contributor

I think it'd be good to think through and add a test for the Early Hints case.

@noamr
Copy link
Contributor

noamr commented Jan 23, 2025

I think it'd be good to think through and add a test for the Early Hints case.

Those tests exists, but I believe they don't have assertions:

https://wpt.fyi/results/loading/early-hints/csp-early-hints-absent-final-disallowed.h2.window.html?label=master&label=experimental&aligned&q=early

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamr noamr Awaiting requested review from noamr

@snuggs snuggs Awaiting requested review from snuggs

@yoavweiss yoavweiss Awaiting requested review from yoavweiss

At least 1 approving review is required to merge this pull request.

Assignees

@yoavweiss yoavweiss

Labels
preload wg-s_webperf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nidhijaju @yoavweiss @noamr @wpt-pr-bot