Create figure-name-no-figcaption.tentative.html #49647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a figcaption should not provide a name to a figure element per w3c/aria#2224
if a figure has an aria-labelledby pointing to its own figcaption, **then** it can be the accName for the figure.
|
@hidde @giacomo-petri @adampage to review |
cookiecrook
requested changes
Dec 13, 2024
There was a problem hiding this comment.
2 of the 5 tests seem like incorrect expectations to me. See comments.
Update: Scott and I chatted, and are working on a update that will account for this HTML text:
- If the image is a descendant of a figure element that has a child figcaption element, and, ignoring the figcaption element and its descendants, the figure element has no flow content descendants other than inter-element whitespace and the img element, then return the contents of the first such figcaption element.
|
also flagged that in the spec PR: w3c/aria#2224 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a figcaption should not provide a name to a figure element per w3c/aria#2224