-
Notifications
You must be signed in to change notification settings - Fork 152
Lint feature descriptions with Vale #3045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
StylesPath = .vale | ||
|
||
[features/*.yml] | ||
View = features | ||
BasedOnStyles = Vale, web-features-styles | ||
Vale.Spelling = NO |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
engine: dasel | ||
scopes: | ||
- name: description | ||
expr: description | ||
type: md |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
extends: existence | ||
message: Consider removing '%s' | ||
level: warning | ||
ignorecase: true | ||
tokens: | ||
- is used to |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
extends: substitution | ||
message: Consider using '%s' instead of '%s' | ||
level: warning | ||
ignorecase: false | ||
# swap maps tokens in form of bad: good | ||
swap: | ||
defines: sets | ||
specifies: sets | ||
determines: sets |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: "@charset" | ||
description: The `@charset` CSS at-rule specifies the character encoding of an external style sheet. | ||
description: The `@charset` CSS at-rule specifies the character encoding of an external style sheet. | ||
Check warning on line 2 in features/charset.yml
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this file so it would get flagged on review. Before merging, I ought to undo this change, to show I'm just ignoring this suggestion. |
||
spec: https://drafts.csswg.org/css2/#charset | ||
group: css | ||
compat_features: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: <del> | ||
description: The `<del>` element element represents a range of text that has been deleted from a document, styling text as strikethrough by default. | ||
description: The `<del>` element element represents a range of text that has been deleted from a document, styling text as strikethrough by default. | ||
Check failure on line 2 in features/del.yml
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this file so it would get flagged on review. Before merging, I ought to push a change fixing it. |
||
spec: https://html.spec.whatwg.org/multipage/edits.html#the-del-element | ||
group: html-elements | ||
compat_features: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: font-kerning | ||
description: The `font-kerning` CSS property sets whether kerning data from a font is used to adjust the space between letters. | ||
description: The `font-kerning` CSS property sets whether to use kerning data from a font to adjust the space between letters. | ||
spec: https://drafts.csswg.org/css-fonts-4/#font-kerning-prop | ||
group: font-features | ||
caniuse: font-kerning |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
name: Idle detection | ||
description: The `IdleDetector` API is used to notify a webpage of the user's idle, active, and locked state. | ||
description: The `IdleDetector` API notifies a webpage of the user's idle, active, and locked state. | ||
spec: https://wicg.github.io/idle-detection/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and several other feature changes) fix warnings or errors from Vale.