Update webdriver-bidi with the new BCD keys #2777
Conversation
github-actions
bot
added
the
feature definition
| # ⬇️ Same status as overall feature ⬇️ | ||
| # baseline: false | ||
| # support: {} | ||
| - webdriver.bidi.browsingContext.print | ||
| - webdriver.bidi.network.addIntercept | ||
| - webdriver.bidi.network.beforeRequestSent_event | ||
| - webdriver.bidi.network.continueRequest | ||
| - webdriver.bidi.network.continueResponse | ||
| - webdriver.bidi.network.provideResponse | ||
| - webdriver.bidi.network.responseCompleted_event | ||
| - webdriver.bidi.network.responseStarted_event | ||
| - webdriver.bidi.session.end | ||
| - webdriver.bidi.webExtension | ||
| - webdriver.bidi.webExtension.install | ||
| - webdriver.bidi.webExtension.uninstall |
There was a problem hiding this comment.
These keys are not supported anywhere. Good candidates to move elsewhere if they belong to a separate feature / later addition. Are they later additions to bidi? Are they needed to use bidi, or separate capabilities?
There was a problem hiding this comment.
The webExtension module is a later addition to the spec. I think we should pin support to the earliest parts of BiDi, and treat this as a later addition.
| # baseline: false | ||
| # support: | ||
| # chrome: "126" | ||
| # chrome_android: "126" | ||
| # edge: "126" | ||
| - webdriver.bidi.browsingContext.contextCreated_event | ||
| - webdriver.bidi.browsingContext.contextDestroyed_event | ||
| - webdriver.bidi.browsingContext.create | ||
| - webdriver.bidi.browsingContext.locateNodes | ||
| - webdriver.bidi.browsingContext.navigate | ||
| - webdriver.bidi.browsingContext.navigationCommitted_event | ||
| - webdriver.bidi.browsingContext.navigationFailed_event | ||
| - webdriver.bidi.browsingContext.reload | ||
| - webdriver.bidi.browsingContext.setViewport | ||
| - webdriver.bidi.browsingContext.traverseHistory | ||
| - webdriver.bidi.browsingContext.userPromptClosed_event | ||
| - webdriver.bidi.browsingContext.userPromptOpened_event | ||
| - webdriver.bidi.input.setFiles | ||
| - webdriver.bidi.log.entryAdded_event | ||
| - webdriver.bidi.network.continueWithAuth | ||
| - webdriver.bidi.script.getRealms | ||
| - webdriver.bidi.script.realmCreated_event | ||
| - webdriver.bidi.session.new | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "133" | ||
| # chrome_android: "133" | ||
| # edge: "133" | ||
| - webdriver.bidi.network.fetchError_event | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # firefox: "122" | ||
| # firefox_android: "122" | ||
| - webdriver.bidi.network.authRequired_event | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # firefox: "134" | ||
| # firefox_android: "134" | ||
| - webdriver.bidi.browser.getClientWindows |
There was a problem hiding this comment.
These keys are supported either in chromium or in firefox, but not in both, unlike the keys that come before them.
Are they later additions? Should we ignore them from the initial bidi feature and put them into other features?
There was a problem hiding this comment.
It's relatively new, from w3c/webdriver-bidi#752. I think we should just let them be later additions while pinning the overall feature to the basics.
|
@juliandescottes it'd be great if someone close to the bidi project could take a look at this PR. Feel free to at-mention other people if needed. One question here is: of the BCD keys in this PR, which represent an initial bidi feature, and more or less match our previously hard-coded data (see PR description). Also, are there groups of keys we can split out into separate features? Did some of these key come later and represent pieces of capability that developers can use separately from the rest? Thanks! |
|
The WebDriver BiDi keys look good to me. In general, each feature/method could be used separately by the users depending on the use case. They could be grouped by the module (e.g., |
I find this is a great starting point, which can be updated/fixed in case of some inaccuracy. |
BCD v5.7.0 introduces new keys for webdriver bidi.
The webdriver bidi feature on this repo used to be hardcoded to the following browser versions:
According to comments that we left when the feature was created, these versions numbers were based on:
Now that BCD has webdriver bidi keys, we can remove our hard-coded values and just start using BCD keys instead. However, doing so in one go, by just adding all of the new BCD keys to our features, makes the feature unsupported on all browsers.
So, we now need to look at the various support data for each key and decide which keys should be part of the feature, which keys might need to be ignored (if any), and which keys should be considered for separate features.