-
Notifications
You must be signed in to change notification settings - Fork 144
Update webdriver-bidi with the new BCD keys #2777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@juliandescottes it'd be great if someone close to the bidi project could take a look at this PR. Feel free to at-mention other people if needed. One question here is: of the BCD keys in this PR, which represent an initial bidi feature, and more or less match our previously hard-coded data (see PR description). Also, are there groups of keys we can split out into separate features? Did some of these key come later and represent pieces of capability that developers can use separately from the rest? Thanks! |
The WebDriver BiDi keys look good to me. In general, each feature/method could be used separately by the users depending on the use case. They could be grouped by the module (e.g., |
I find this is a great starting point, which can be updated/fixed in case of some inaccuracy. |
@ddbeck I had a very informative discussion with @juliandescottes where he went over each and every key told me what each one covered and whether it was important for a basic usage of WebDriver BiDi. Based on this, I left a lot of comments for posterity, and moved a few keys only to In doing so, I was still getting no browser supported in the dist file. So I ended up commenting out a bunch of keys, and later found out that they were causing this status mostly because they are marked as partially supported in BCD for Firefox. I understand that this might change soon, as some/all of the features for these commented out keys are actually supported in Firefox, modulo some minor edge cases. So the data in BCD might change soon, and we might be able to uncomment some of the Let me know what you think of this approach. We could also simplify the
(although these act as "container" features in BCD and don't actually match with anything a developer might do) |
@captainbrosset regarding the So if you want to create something for baseline you probably can take the For me it's currently helpful information to see which commands are fully completed and which aren't. Especially until we have a way to as well cover the relevant payload properties as well. Adding that is quite a bit of work and I'm still not sure if the spreadsheet is the best choice for it (given that it is manually updated and might cause the script from @caugner to break completely). So would it work for you to account |
Quick update: @whimboo has started adding parameter-level implementation status to the spreadsheet. |
Note that for both Firefox and Chrome the versions for parameters of commands and events have been entered. So we could do another BCD update. |
BCD v5.7.0 introduces new keys for webdriver bidi.
The webdriver bidi feature on this repo used to be hardcoded to the following browser versions:
According to comments that we left when the feature was created, these versions numbers were based on:
Now that BCD has webdriver bidi keys, we can remove our hard-coded values and just start using BCD keys instead. However, doing so in one go, by just adding all of the new BCD keys to our features, makes the feature unsupported on all browsers.
So, we now need to look at the various support data for each key and decide which keys should be part of the feature, which keys might need to be ignored (if any), and which keys should be considered for separate features.