-
Notifications
You must be signed in to change notification settings - Fork 128
Rename leading-trim to text-box-trim #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The spec link hasn't changed, but the property was renamed: w3c/csswg-drafts@67822bd
@ddbeck this removes a feature, do you think we should create the mechanism for feature aliases as part of this? Or just bump the major version? |
@foolip Since we're pre-1.0, we can make changes and increment the minor version freely (i.e., the next release would be 0.5.0). I think we ought to figure out aliases (and offer some API that follows them automatically) at some point, but it doesn't need to be for this PR. That said, if we wanted to stake out a way of annotating feature aliases now, it might be nice. I think you've got three options for this PR:
I'm fine with any one of these and if there's no action (or you go on leave before you've had a chance to take action), then I'll merge on the presumption of option 3. |
@ddbeck I went ahead with an |
Works for me. I just pushed a commit for the schema change (like you said, straightforward) and I'll deal with the version bump on the next release. Thank you, @foolip! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
The spec link hasn't changed, but the property was renamed: w3c/csswg-drafts@67822bd