Skip to content

Rename leading-trim to text-box-trim #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Rename leading-trim to text-box-trim #202

merged 3 commits into from
Jun 16, 2023

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented May 23, 2023

The spec link hasn't changed, but the property was renamed: w3c/csswg-drafts@67822bd

The spec link hasn't changed, but the property was renamed:
w3c/csswg-drafts@67822bd
@foolip foolip requested a review from ddbeck May 23, 2023 10:44
@foolip
Copy link
Collaborator Author

foolip commented May 23, 2023

@ddbeck this removes a feature, do you think we should create the mechanism for feature aliases as part of this? Or just bump the major version?

@ddbeck
Copy link
Collaborator

ddbeck commented Jun 16, 2023

@foolip Since we're pre-1.0, we can make changes and increment the minor version freely (i.e., the next release would be 0.5.0). I think we ought to figure out aliases (and offer some API that follows them automatically) at some point, but it doesn't need to be for this PR.

That said, if we wanted to stake out a way of annotating feature aliases now, it might be nice. I think you've got three options for this PR:

  1. Stake out a place for aliases/formerly known as-es/nées or however you want to call it, in this PR or another PR that blocks this one.
  2. Add a comment to Consider handling feature identifier changes or aliases #91, describing this rename and perhaps what you might've noted this alias (e.g., in this file, in another file, etc.)
  3. Do nothing.

I'm fine with any one of these and if there's no action (or you go on leave before you've had a chance to take action), then I'll merge on the presumption of option 3.

@foolip
Copy link
Collaborator Author

foolip commented Jun 16, 2023

@ddbeck I went ahead with an alias property. I'm on my phone (not working) and it's not convenient to update the schema. It should be a very straightforward change however, if you want to make it and bump the version I can approve it, before landing this.

@ddbeck
Copy link
Collaborator

ddbeck commented Jun 16, 2023

Works for me. I just pushed a commit for the schema change (like you said, straightforward) and I'll deal with the version bump on the next release. Thank you, @foolip!

Copy link
Collaborator Author

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@foolip foolip merged commit c9314c5 into main Jun 16, 2023
@foolip foolip deleted the text-box-trim branch June 16, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants