-
-
Notifications
You must be signed in to change notification settings - Fork 746
test: try to fix flaky test cases #12402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses flaky test cases through two targeted improvements: enhancing test output verbosity in CI environments and ensuring unique loader identifiers to prevent test collisions.
- Added
chaiConfigwith increasedtruncateThresholdfor CI to show complete assertion details in test failures - Fixed indentation inconsistencies in the test configuration
- Modified loader
identto include issuer, resource, and resourceQuery for guaranteed uniqueness
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/rspack-test/rstest.config.ts | Added chaiConfig for CI environments to display more detailed test assertion output, and corrected indentation for DEFAULT_MAX_CONCURRENT |
| tests/rspack-test/configCases/rule-set/custom/rspack.config.js | Enhanced loader ident to include issuer, resource, and resourceQuery, preventing identifier collisions when the same resource is loaded from different contexts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 project(s) in monorepo. 📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-1kPath:
📦 Download Diff Report: react-1k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🙈 Size remains the same at 48.21MB |
CodSpeed Performance ReportMerging #12402 will not alter performanceComparing Summary
|
7922ad9 to
b038fa8
Compare
b038fa8 to
a6f5639
Compare
Summary
fix native watcher flaky test cases
Related links
Checklist