Skip to content

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Dec 10, 2025

Summary

fix native watcher flaky test cases

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 10, 2025 03:48
@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit a6f5639
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/693a9620fed37000080039a1
😎 Deploy Preview https://deploy-preview-12402--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses flaky test cases through two targeted improvements: enhancing test output verbosity in CI environments and ensuring unique loader identifiers to prevent test collisions.

  • Added chaiConfig with increased truncateThreshold for CI to show complete assertion details in test failures
  • Fixed indentation inconsistencies in the test configuration
  • Modified loader ident to include issuer, resource, and resourceQuery for guaranteed uniqueness

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/rspack-test/rstest.config.ts Added chaiConfig for CI environments to display more detailed test assertion output, and corrected indentation for DEFAULT_MAX_CONCURRENT
tests/rspack-test/configCases/rule-set/custom/rspack.config.js Enhanced loader ident to include issuer, resource, and resourceQuery, preventing identifier collisions when the same resource is loaded from different contexts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: b73f59a9a4 | PR: #12420

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: b73f59a9a4 | PR: #12420

Metric Current Baseline Change
📊 Total Size 823.6 KB 823.6 KB 0 B (0.0%)
📄 JavaScript 823.6 KB 823.6 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: b73f59a9a4 | PR: #12420

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: b73f59a9a4 | PR: #12420

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB 0 B (0.0%)
📄 JavaScript 984.3 KB 984.3 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: b73f59a9a4 | PR: #12420

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB 0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB 0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📦 Binary Size-limit

Comparing a6f5639 to chore: improve AGENTS.md and add project architecture documentation (#12420) by harpsealjs

🙈 Size remains the same at 48.21MB

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #12402 will not alter performance

Comparing test/fix-flaky (a6f5639) with main (b73f59a)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder enabled auto-merge (squash) December 11, 2025 13:25
@LingyuCoder LingyuCoder merged commit f9653b1 into main Dec 11, 2025
208 of 210 checks passed
@LingyuCoder LingyuCoder deleted the test/fix-flaky branch December 11, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants