Skip to content

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Aug 22, 2025

Summary

sync test form https://redirect.github.com/web-infra-dev/rspack/pull/11418.

need to wait Rspack bump to rc version.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 06:31
@fi3ework fi3ework marked this pull request as draft August 22, 2025 06:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds more comprehensive test coverage for APIPlugin interception by expanding the test to verify multiple require API properties are properly handled during bundling.

  • Expands the existing APIPlugin test to cover additional require properties (extensions, config, version, include, onError)
  • Updates test expectations to verify all API properties are correctly intercepted and preserved in both ESM and CJS outputs
  • Standardizes quote style from single to double quotes throughout the test file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/integration/format/index.test.ts Updates test expectations to verify interception of multiple require API properties and standardizes quote usage
tests/integration/format/api-plugin/src/index.js Adds exports for additional require API properties to test comprehensive APIPlugin functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant